Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: BB-311 add oplog populator alerts #2359

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Feature: BB-311 add oplog populator alerts #2359

merged 2 commits into from
Jan 6, 2023

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Dec 23, 2022 •
edited by jira bot
Loading

Issue: BB-311

@bert-e
Copy link
Contributor

bert-e commented Dec 23, 2022

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 23, 2022

Incorrect fix version

The Fix Version/s in issue BB-311 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.6.2

Please check the Fix Version/s of BB-311, or the target
branch of this pull request.

@Kerkesni Kerkesni force-pushed the feature/BB-311-add-oplog-populator-alerts branch from 58b846b to 94a53b7 Compare December 23, 2022 11:17
@Kerkesni Kerkesni changed the base branch from development/8.6 to development/8.4 December 23, 2022 11:38
@bert-e
Copy link
Contributor

bert-e commented Dec 23, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Dec 23, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni Kerkesni force-pushed the feature/BB-311-add-oplog-populator-alerts branch from 94a53b7 to da1844b Compare January 3, 2023 12:42
@bert-e
Copy link
Contributor

bert-e commented Jan 3, 2023

History mismatch

Merge commit #e15ab49688af9d583098452d642a4255f814f243 on the integration branch
w/8.5/feature/BB-311-add-oplog-populator-alerts is merging a branch which is neither the current
branch feature/BB-311-add-oplog-populator-alerts nor the development branch
development/8.5.

It is likely due to a rebase of the branch feature/BB-311-add-oplog-populator-alerts and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@Kerkesni
Copy link
Contributor Author

Kerkesni commented Jan 3, 2023

/reset

@bert-e
Copy link
Contributor

bert-e commented Jan 3, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Jan 3, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jan 3, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

francoisferrand
francoisferrand reviewed Jan 3, 2023
View reviewed changes
Copy link
Contributor

@francoisferrand francoisferrand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also have alerts:

  • if the we fail to update kafka-connect config
  • if updating kafka-connect config takes too long (since metastore update)

@francoisferrand
Copy link
Contributor

Also, practically this PR may be stacked in #2358 : to avoid merge conflicts eventually...

@Kerkesni Kerkesni force-pushed the feature/BB-311-add-oplog-populator-alerts branch from da1844b to 68376d9 Compare January 4, 2023 14:09
@bert-e
Copy link
Contributor

bert-e commented Jan 4, 2023 •
edited by jira bot
Loading

History mismatch

Merge commit #525eed9406b905a16a784e6c970fff00416f7ef8 on the integration branch
w/8.5/feature/BB-311-add-oplog-populator-alerts is merging a branch which is neither the current
branch feature/BB-311-add-oplog-populator-alerts nor the development branch
development/8.5.

It is likely due to a rebase of the branch feature/BB-311-add-oplog-populator-alerts and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@Kerkesni Kerkesni force-pushed the feature/BB-311-add-oplog-populator-alerts branch from 3620ec9 to 958f84f Compare January 6, 2023 14:43
@Kerkesni Kerkesni force-pushed the feature/BB-311-add-oplog-populator-alerts branch from 958f84f to cd2c0ab Compare January 6, 2023 17:49
@Kerkesni
Copy link
Contributor Author

Kerkesni commented Jan 6, 2023

/reset

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni
Copy link
Contributor Author

Kerkesni commented Jan 6, 2023

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.4

  • ✔️ development/8.5

  • ✔️ development/8.6

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/8.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.4

  • ✔️ development/8.5

  • ✔️ development/8.6

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/8.3

Please check the status of the associated issue BB-311.

Goodbye kerkesni.

@bert-e bert-e merged commit 6e3006e into development/8.4 Jan 6, 2023
@bert-e bert-e deleted the feature/BB-311-add-oplog-populator-alerts branch January 6, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XinLi0207 XinLi0207 XinLi0207 approved these changes

@francoisferrand francoisferrand francoisferrand approved these changes

@williamlardier williamlardier Awaiting requested review from williamlardier

@dvasilas dvasilas Awaiting requested review from dvasilas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kerkesni @bert-e @francoisferrand @XinLi0207 @williamlardier